Fixing Silicon issue #753 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoeilers
added a commit
that referenced
this pull request
Oct 17, 2023
marcoeilers
added a commit
that referenced
this pull request
Oct 17, 2023
Added missing case (fixes Silicon issue #742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing computation of required domain axiom instantiations (and removing a default case that shouldn't be necessary in the process). This fixes Silicon issue viperproject/silicon#753 and two duplicates.
Also adding a test for a previously fixed Silicon issue because I don't want to make a separate PR.