-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes Injectivity Assumptions on Inhale #409
base: master
Are you sure you want to change the base?
Conversation
Before merging this, I would also like to run it with verifiedSCION |
Makes sense. I've just opened this PR to detect possible issues before the Viper release. Might make sense to run your experiments sooner than later in case we need to defer the Viper release |
8a0a790
to
74adad8
Compare
I believe it makes sense to merge these changes before I start looking at enabling the consistency checks. I am now running tests locally on the verified scion repository. @ArquintL should we disable the dense_sparse_matrix tests? Or did you find a way to make them pass the injectivity tests? |
This reverts commit dbfdcd2.
@ArquintL should we close this PR? Right now, it seems unlikely that it will be merged. Regarding the changes to the encoding, if you think it is worth keeping, maybe we can open a PR for that already |
The only changes to me seems to be that I use
|
Fixes #427