Add dicts and gomap packages #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcp19
reviewed
Feb 19, 2024
|
As discussed in the meeting, I will look at the PR again when the changes to the theorems about Go maps are adapted. |
jcp19
reviewed
Feb 21, 2024
jcp19
reviewed
Feb 29, 2024
jcp19
reviewed
Mar 4, 2024
jcp19
previously approved these changes
Mar 11, 2024
| decreases | ||
| pure func Agree(m1, m2 map[int]int) (result bool) { | ||
| return forall k int :: {m1[k], m2[k]} k in (domain(m1) intersection domain(m2)) ==> | ||
| m1[k] == m2[k] |
There was a problem hiding this comment.
identation looks inconsistent
There was a problem hiding this comment.
I agree that it looks off; however, it is consistent in the sense that in forall x :: a ==> b, if b is in a new line, it is indented by one relative to forall (compare with IsMonotonic and IsInjective, for example) . Removing that indentation everywhere probably will look off again somewhere.
There was a problem hiding this comment.
I think that, in some places, the indentation is relative to the the return. At any rate, let's ignore it for now. Hopefully, we will have an automated formatter at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.