Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper binary for extracting axiom dependencies #50

Merged
merged 11 commits into from
Jun 1, 2024
Merged

Conversation

JonasAlaif
Copy link
Collaborator

Duplicate of #45, I just don't have permissions to push to your fork. @Gopiandcode could you enable this in the future :)

@JonasAlaif
Copy link
Collaborator Author

Responding to the PR: this looks great! I will pull this into the main crate

@kiranandcode
Copy link
Contributor

ah, whoops, my bad!! will enable that in the future, can't believe I missed that lol!

@JonasAlaif
Copy link
Collaborator Author

@Gopiandcode I've made some changes, let me know if everything still works for you or if I broke something. The main change is that I keep around the InstIdx for much longer instead of using RawNodeIndex (the missing link is that one can go from the former to the latter using the InstIdx as IndexesInstGraph trait). I also switched to petgraph::Dfs which requires some not very nice EdgeFiltered and Reversed adaptors but still nicer than doing the dfs manually imo

@kiranandcode
Copy link
Contributor

Ooh, yep, this looks good! Lemme try it out!

@kiranandcode
Copy link
Contributor

Awesome, tried it out! Works great!

@JonasAlaif JonasAlaif merged commit 7ddf410 into main Jun 1, 2024
8 checks passed
@JonasAlaif JonasAlaif deleted the smt-dependencies-2 branch June 1, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants