Term generalisation with shared parser #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit faea524.
JonasAlaif
force-pushed
the
term_generalisation_with_SharedParser
branch
from
851bf41
to
0b51f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version, I'm just adding the generalised terms to the end of
Terms::terms. I have not yet implemented the hash-map for avoiding duplicate generalised terms so it's not particularly memory-efficient yet.Also, the buckets for the edges are still just based on the quantifiers of the end-nodes.
EDIT: hash-map for avoiding duplicate generalised terms has now been implemented
EDIT 2: the buckets for the edges are now also based on the trigger used for the instantiation