Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch connector version correctly #12

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

buinauskas
Copy link
Collaborator

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

Currently, the connector version is shown as 0.0.0.0.

[
  {
    "class": "com.vinted.kafka.connect.vespa.VespaSinkConnector",
    "type": "sink",
    "version": "0.0.0.0"
  }
]

After the change, it is correctly taken from pom.xml file.

[
  {
    "class": "com.vinted.kafka.connect.vespa.VespaSinkConnector",
    "type": "sink",
    "version": "1.0.5-SNAPSHOT"
  }
]

Testing

  • Did you add testing to account for any new or changed work?

Review notes

Issues Closed or Referenced

  • Closes # (this will automatically close the issue when the PR closes)
  • References # (this references the issue but does not close with PR)

@buinauskas buinauskas merged commit 15c2eb0 into master Oct 2, 2023
2 checks passed
@buinauskas buinauskas deleted the feat/fix_version_resolving branch October 2, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant