Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use propagation for error handling #10

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

buinauskas
Copy link
Collaborator

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

We do have some weird exceptions saying that 0 hits were fed successfully. I find it hard to replicate in code with my current Java knowledge. I suspect that can come from weird error handling and the fact I barely know how to work with Java completion stages. Error propagation seems a better approach to conditionally handle exceptions than throwing exceptions inside completion stages.

Testing

The current test suite passes just fine.

Review notes

Issues Closed or Referenced

  • Closes # (this will automatically close the issue when the PR closes)
  • References # (this references the issue but does not close with PR)

@buinauskas buinauskas merged commit 71dc337 into master Oct 2, 2023
2 checks passed
@buinauskas buinauskas deleted the fix/zero_feed_operations_failed branch October 2, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant