bump to 3-1-stable #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay3011
reviewed
Jun 29, 2017
|
|
||
| def index | ||
| render | ||
| @csv_table = CSV.open(SAMPLE_CSV_FILES[:sample_order_file], headers: true).read if File.exists? SAMPLE_CSV_FILES[:sample_order_file] |
There was a problem hiding this comment.
Please change the name of this constant
tanmay3011
reviewed
Jun 29, 2017
| end | ||
|
|
||
| def download_sample_csv | ||
| send_file SAMPLE_CSV_FILE | ||
| send_file SAMPLE_CSV_FILES[:sample_order_file] |
tanmay3011
reviewed
Jun 29, 2017
| begin | ||
| loader = DataShift::SpreeEcom::ShopifyOrderLoader.new(Spree::Order, { verbose: true }) | ||
| loader.perform_load(SAMPLE_CSV_FILES[:sample_order_file]) | ||
| flash[:success] = Spree.t(:successfull_import, resource: 'Orders') |
There was a problem hiding this comment.
Please inherit this from model name
tanmay3011
reviewed
Jun 29, 2017
| begin | ||
| loader = DataShift::SpreeEcom::ShopifyOrderLoader.new(Spree::Order, { verbose: true }) | ||
| loader.perform_load(params[:csv_file].path) | ||
| flash[:success] = Spree.t(:successfull_import, resource: 'Orders') |
tanmay3011
reviewed
Jun 29, 2017
| @@ -1,52 +1,60 @@ | |||
| class Spree::Admin::OrderImportsController < Spree::Admin::BaseController | |||
| SAMPLE_CSV_FILE = Rails.root.join("sample_csv", "orders_export_multiple_paid-fulfilled.csv") | |||
|
|
|||
There was a problem hiding this comment.
Use scope for internationalization.
tanmay3011
reviewed
Jun 29, 2017
| class DataResetService | ||
|
|
||
| def reset_users(users = []) | ||
| users = Spree::User.non_admins.all unless users.present? |
…es for listing and forms of import
…nfiguration Add enable/disable configuration for resetting of data and add UI fix…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.