Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 1 0 backport #36

Closed
wants to merge 18 commits into from
Closed

3 1 0 backport #36

wants to merge 18 commits into from

Conversation

nimish-mehta
Copy link

Backporting changes made in #33

tanmay3011 and others added 18 commits June 27, 2016 10:55
Update gem name from spree_reportify to spree_admin_insights
…issue

Get db config from ActiveRecord::Base.
changes params for Sequel connection(for sqlite db)
1. Standardize on report_category instead of using type and category alternatively.
2. Add initializer to configure list of reports to be used.
3. Reduce responsibility of report generation service to just generate reports
@tanmay3011
Copy link
Member

Closing this wrt PR #37

@tanmay3011 tanmay3011 closed this Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants