Skip to content

Commit

Permalink
fix: not keeping the update toggle-button state after a filter is app…
Browse files Browse the repository at this point in the history
…lied
  • Loading branch information
vinifmor committed Oct 24, 2019
1 parent 1a4ccfc commit c631ecd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Improvements
- 3 password attempts for root authentication
- not changing the table applied filters after a uninstall
- cleaning the progress bar substatus after each upgrade
- AppImage:
- showing an error popup when **AppImageLauncher** messes up with an application installation
- Flatpak:
Expand All @@ -37,6 +38,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- application not initializing when there is no internet connection
- not loading application icons after some filters are applied to the table results
- not reloading the available categories after asynchronous data is fetched
- not keeping the update toggle-button state after a filter is applied
- AUR:
- update-checking for some scenarios
- not respecting **ignorepkg** settings in **pacman.conf**
Expand Down
2 changes: 1 addition & 1 deletion bauh/view/qt/apps_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def _update_row(self, pkg: PackageView, update_check_enabled: bool = True, chang
col_update = None

if update_check_enabled and pkg.model.update:
col_update = UpdateToggleButton(pkg, self.window, self.i18n, pkg.model.update)
col_update = UpdateToggleButton(pkg, self.window, self.i18n, pkg.update_checked)

self.setCellWidget(pkg.table_index, 7, col_update)

Expand Down
4 changes: 2 additions & 2 deletions bauh/view/qt/thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ def change_status(self, status: str):
self.signal_status.emit(status)

def change_substatus(self, substatus: str):
if substatus:
self.signal_substatus.emit(substatus)
self.signal_substatus.emit(substatus)

def change_progress(self, val: int):
if val is not None:
Expand Down Expand Up @@ -96,6 +95,7 @@ def run(self):

self.change_status('{} {} {}...'.format(self.locale_keys['manage_window.status.upgrading'], name, app.model.version))
success = bool(self.manager.update(app.model, self.root_password, self))
self.change_substatus('')

if not success:
break
Expand Down

0 comments on commit c631ecd

Please sign in to comment.