Make swingx/MaterialTaskPaneUI optional #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will gracefully catch NoClassDefFoundError in case swingx is not present in the classpath, allowing material ui to be used without it.
There was a problem hiding this comment.
Thanks! I left a small comment and I think that swingx is used by @zanderson9 inside JMars, so maybe she need to be ping too
This will tell people that swingx is optional and can be excluded using their dependency management tools.
vincenzopalazzo
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will gracefully catch NoClassDefFoundError in case swingx is not present in the classpath, allowing material ui to be used without it.
In the end, I've decided against making swingx compileOnly as it would require more changes than needed, consumers instead can exclude swingx if they desire.
For making MaterialTaskPaneUI optional, I decided to try-catch the class initialization instead of using a plain string with the class name to keep consistency with all other field declarations, but had to move it to a static block to do so.
Fixes #198