fix(jackson): revert JsonTypeInfo for every dto (#92)

vincejv · Oct 31, 2022 · 79b8249 · 79b8249
1 parent 0883b2a
commit 79b8249
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 9 deletions.
diff --git a/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/IDto.java b/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/IDto.java
@@ -19,7 +19,6 @@
 import java.io.Serializable;
 
 import com.abavilla.fpi.fw.util.MapperUtil;
-import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import com.fasterxml.jackson.databind.JsonNode;
 
 /**
@@ -28,7 +27,6 @@
  *
  * @author <a href="mailto:[email protected]">Vince Villamora</a>
  */
-@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS)
 public interface IDto extends Serializable {
 
   /**

diff --git a/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/impl/NullDto.java b/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/impl/NullDto.java
@@ -19,7 +19,6 @@
 import com.abavilla.fpi.fw.controller.AbsBaseResource;
 import com.abavilla.fpi.fw.dto.AbsDto;
 import com.abavilla.fpi.fw.service.AbsSvc;
-import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import io.quarkus.runtime.annotations.RegisterForReflection;
 
 /**
@@ -29,6 +28,5 @@
  * @author <a href="mailto:[email protected]">Vince Villamora</a>
  */
 @RegisterForReflection
-@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, defaultImpl = NullDto.class)
 public class NullDto extends AbsDto {
 }
diff --git a/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/impl/PageDto.java b/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/impl/PageDto.java
@@ -20,7 +20,6 @@
 
 import com.abavilla.fpi.fw.dto.AbsDto;
 import com.abavilla.fpi.fw.dto.IDto;
-import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import io.quarkus.runtime.annotations.RegisterForReflection;
 import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
@@ -39,7 +38,6 @@
 @ToString(callSuper = true)
 @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
 @RegisterForReflection
-@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, defaultImpl = PageDto.class)
 public class PageDto<D extends IDto> extends AbsDto {
 
   /**

diff --git a/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/impl/RespDto.java b/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/dto/impl/RespDto.java
@@ -33,12 +33,12 @@
 @Data
 @EqualsAndHashCode(callSuper = true)
 @RegisterForReflection
-@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, defaultImpl = RespDto.class)
 public class RespDto<T extends IDto> extends AbsDto {
 
   /**
    * API Response
    */
+  @JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, include = JsonTypeInfo.As.EXTERNAL_PROPERTY, property = "respType")
   private T resp;
 
   /**

diff --git a/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/entity/enums/SampleEnum.java b/fpi-framework-core/src/main/java/com/abavilla/fpi/fw/entity/enums/SampleEnum.java
@@ -23,7 +23,6 @@
 import java.util.Map;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonTypeInfo;
 import com.fasterxml.jackson.annotation.JsonValue;
 import io.quarkus.runtime.annotations.RegisterForReflection;
 import lombok.AllArgsConstructor;
@@ -38,7 +37,6 @@
 @Getter
 @AllArgsConstructor
 @RegisterForReflection
-@JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, defaultImpl = SampleEnum.class)
 public enum SampleEnum implements IBaseEnum {
 
   /**