Apply rector fixes

.github/workflows/windows-ci.yml

@@ -55,10 +55,12 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: '8.1'
-          ini-values: zend.assertions=1, assert.exception=1, opcache.enable_cli=1, opcache.jit=function, opcache.jit_buffer_size=512M
+          #ini-values: zend.assertions=1, assert.exception=1, opcache.enable_cli=1, opcache.jit=function, opcache.jit_buffer_size=512M
+          ini-values: zend.assertions=1, assert.exception=1
           tools: composer:v2
           coverage: none
-          extensions: none, curl, dom, filter, intl, json, libxml, mbstring, openssl, opcache, pcre, phar, reflection, simplexml, spl, tokenizer, xml, xmlwriter
+          #extensions: none, curl, dom, filter, intl, json, libxml, mbstring, openssl, opcache, pcre, phar, reflection, simplexml, spl, tokenizer, xml, xmlwriter
+          extensions: none, curl, dom, filter, intl, json, libxml, mbstring, openssl, pcre, phar, reflection, simplexml, spl, tokenizer, xml, xmlwriter
         env:
           fail-fast: true
 

config.xsd

@@ -429,6 +429,7 @@
             <xs:element name="ReferenceReusedFromConfusingScope" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="ReservedWord" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="RiskyCast" type="IssueHandlerType" minOccurs="0" />
+            <xs:element name="RiskyTruthyFalsyComparison" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="StringIncrement" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="TaintedCallable" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="TaintedCookie" type="IssueHandlerType" minOccurs="0" />

docs/running_psalm/error_levels.md

@@ -246,6 +246,7 @@ Level 5 and above allows a more non-verifiable code, and higher levels are even
 - [RedundantConditionGivenDocblockType](issues/RedundantConditionGivenDocblockType.md)
 - [RedundantFunctionCallGivenDocblockType](issues/RedundantFunctionCallGivenDocblockType.md)
 - [ReferenceConstraintViolation](issues/ReferenceConstraintViolation.md)
+- [RiskyTruthyFalsyComparison](issues/RiskyTruthyFalsyComparison.md)
 - [UndefinedTrace](issues/UndefinedTrace.md)
 - [UnresolvableInclude](issues/UnresolvableInclude.md)
 - [UnsafeInstantiation](issues/UnsafeInstantiation.md)

docs/running_psalm/issues.md

@@ -230,6 +230,7 @@
  - [ReferenceReusedFromConfusingScope](issues/ReferenceReusedFromConfusingScope.md)
  - [ReservedWord](issues/ReservedWord.md)
  - [RiskyCast](issues/RiskyCast.md)
+ - [RiskyTruthyFalsyComparison](issues/RiskyTruthyFalsyComparison.md)
  - [StringIncrement](issues/StringIncrement.md)
  - [TaintedCallable](issues/TaintedCallable.md)
  - [TaintedCookie](issues/TaintedCookie.md)

docs/running_psalm/issues/RiskyTruthyFalsyComparison.md

@@ -0,0 +1,29 @@
+# RiskyTruthyFalsyComparison
+
+Emitted when comparing a value with multiple types that can both contain truthy and falsy values.
+
+```php
+<?php
+
+/**
+ * @param array|null $arg
+ * @return void
+ */
+function foo($arg) {
+    if ($arg) {
+        // this is risky, bc the empty array and null case are handled together
+    }
+
+    if (!$arg) {
+        // this is risky, bc the empty array and null case are handled together  
+    }
+}
+```
+
+## Why this is bad
+
+The truthy/falsy type of one variable is often forgotten and not handled explicitly causing hard to track down errors.
+
+## How to fix
+
+Explicitly validate the variable with strict comparison.

examples/TemplateChecker.php

@@ -32,7 +32,7 @@
 
 final class TemplateAnalyzer extends Psalm\Internal\Analyzer\FileAnalyzer
 {
-    const VIEW_CLASS = 'Your\\View\\Class';
+    final public const VIEW_CLASS = 'Your\\View\\Class';
 
     public function analyze(?Context $file_context = null, ?Context $global_context = null): void
     {
@@ -148,7 +148,7 @@ private function checkMethod(MethodIdentifier $method_id, PhpParser\Node $stmt,
     /**
      * @param  array<PhpParser\Node\Stmt> $stmts
      */
-    protected function checkWithViewClass(Context $context, array $stmts): void
+    private function checkWithViewClass(Context $context, array $stmts): void
     {
         $pseudo_method_stmts = [];
 

examples/TemplateScanner.php

@@ -16,7 +16,7 @@
 
 final class TemplateScanner extends Psalm\Internal\Scanner\FileScanner
 {
-    const VIEW_CLASS = 'Your\\View\\Class';
+    final public const VIEW_CLASS = 'Your\\View\\Class';
 
     public function scan(
         Codebase $codebase,

examples/plugins/ClassUnqualifier.php

@@ -29,7 +29,7 @@ public static function afterClassLikeExistenceCheck(
             return;
         }
 
-        if (strpos($candidate_type, '\\' . $fq_class_name) !== false) {
+        if (str_contains($candidate_type, '\\' . $fq_class_name)) {
             $type_tokens = TypeTokenizer::tokenize($candidate_type, false);
 
             foreach ($type_tokens as &$type_token) {

examples/plugins/FunctionCasingChecker.php

@@ -55,7 +55,7 @@ public static function afterMethodCallAnalysis(AfterMethodCallAnalysisEvent $eve
                     $statements_source->getSuppressedIssues(),
                 );
             }
-        } catch (Exception $e) {
+        } catch (Exception) {
             // can throw if storage is missing
         }
     }
@@ -93,7 +93,7 @@ public static function afterFunctionCallAnalysis(AfterFunctionCallAnalysisEvent
                     $statements_source->getSuppressedIssues(),
                 );
             }
-        } catch (Exception $e) {
+        } catch (Exception) {
             // can throw if storage is missing
         }
     }

examples/plugins/InternalChecker.php

@@ -19,7 +19,7 @@ public static function afterStatementAnalysis(AfterClassLikeAnalysisEvent $event
     {
         $storage = $event->getClasslikeStorage();
         if (!$storage->internal
-            && strpos($storage->name, 'Psalm\\Internal') === 0
+            && str_starts_with($storage->name, 'Psalm\\Internal')
             && $storage->location
         ) {
             IssueBuffer::maybeAdd(

examples/plugins/StringChecker.php

@@ -31,8 +31,8 @@ public static function afterExpressionAnalysis(AfterExpressionAnalysisEvent $eve
         if ($expr instanceof PhpParser\Node\Scalar\String_) {
             $class_or_class_method = '/^\\\?Psalm(\\\[A-Z][A-Za-z0-9]+)+(::[A-Za-z0-9]+)?$/';
 
-            if (strpos($statements_source->getFileName(), 'base/DefinitionManager.php') === false
-                && strpos($expr->value, 'TestController') === false
+            if (!str_contains($statements_source->getFileName(), 'base/DefinitionManager.php')
+                && !str_contains($expr->value, 'TestController')
                 && preg_match($class_or_class_method, $expr->value)
             ) {
                 /** @psalm-suppress PossiblyInvalidArrayAccess */