Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing object updates #941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Timing object updates #941

wants to merge 2 commits into from

Conversation

salmoro
Copy link
Contributor

@salmoro salmoro commented Jun 29, 2023

  1. Make updateTimingObject of TimingSrcConnector to be more atomic to increase the accuracy of the player state snapshot captured when updating the TimingObject.
  2. Use Typescript types for TimingObject from https://github.com/chrisguttandin/timing-object instead of declaring in our codebase so that if one uses both packages they're less likely to run into type-related issues.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (af0a78c) to head (537f385).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   72.00%   72.14%   +0.14%     
==========================================
  Files           7        7              
  Lines         575      578       +3     
==========================================
+ Hits          414      417       +3     
  Misses        161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant