Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation rule for vimeo id check #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Validation rule for vimeo id check #92

wants to merge 2 commits into from

Conversation

PoojaJadav
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Tofandel
Tofandel reviewed Feb 7, 2024
View reviewed changes
src/Rules/VimeoVideoId.php
*/
public function passes($attribute, $value)
{
$response = Vimeo::request('/videos/'.$value, [], 'GET');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also check that the id is a valid unsigned bigint as well before the request

It also doesn't handle exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofandel Tofandel Tofandel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PoojaJadav @CLAassistant @Tofandel