Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation change and some features and some corrections #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sumpygump
Copy link

I should have broken down the changes into smaller commits, but let me give a run down of the major changes.

  • Moved the file to be an ftplugin (file-type plugin) so it is automatically sourced when *.php files are opened
  • Added defaults to the configuration settings allowing for overrides in users' .vimrc files
  • Added option to select which tags to be included an in which order for PHP class docblocks
  • Corrected detection of the float var type (the float check in PhpDocType() should be called AFTER the int check because the int regex also matches for floats and will override it inadvertently).
  • Corrected detection of bool var type (in the regex, the escaping backslashes need to be escaped).
  • Updated usage information and suggestions as well as updated the formatting of the file comments
  • Cleaned up the code slightly to ensure indentation was consistent (removed some tabs)

sumpygump and others added 11 commits November 20, 2011 00:20
…ing of user custom default values, added option to specify order and inclusion of docblock tags for classes, corrected detection for bool and float types, updated usage information and file documentation
In you .vimrc, you can also specify the tags and the order they appear for
class docblocks:
let g:pdv_cfg_ClassTags = ["package","author","version"]

Signed-off-by: BlackEagle <[email protected]>
…ntation

use vimrc defined g:pdv_cfg_ClassTags
use local variant l:indent.
Use local variant l:indent instead of indent
- Force blank line before return docblock.
- Allow space before return types.
Add PHP7 return types support.
- Remove extra space after '@return'
- Don't capture '{' if return type and '{' are on the same line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants