feat: add favicon to options

vikejs · Sep 25, 2023 · e941cf6 · e941cf6
1 parent cb170b2
commit e941cf6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/vike-solid/renderer/+config.ts b/vike-solid/renderer/+config.ts
@@ -46,6 +46,9 @@ export default {
     description: {
       env: "server-only",
     },
+    favicon: {
+      env: 'server-only'
+    },
     lang: {
       env: "server-only",
     },
@@ -64,6 +67,7 @@ declare global {
       Layout?: Component;
       title?: string | ((pageContext: PageContext) => string);
       description?: string;
+      favicon?: string
       /**
        * @default 'en'
        */

diff --git a/vike-solid/renderer/+onRenderHtml.tsx b/vike-solid/renderer/+onRenderHtml.tsx
@@ -1,14 +1,6 @@
 export default onRenderHtml;
-import {
-  generateHydrationScript,
-  renderToStream,
-  renderToString,
-} from "solid-js/web";
-import {
-  escapeInject,
-  dangerouslySkipEscape,
-  stampPipe,
-} from "vike/server";
+import { generateHydrationScript, renderToStream, renderToString } from "solid-js/web";
+import { dangerouslySkipEscape, escapeInject, stampPipe } from "vike/server";
 import { getTitle } from "./getTitle";
 import { getPageElement } from "./getPageElement";
 import type { PageContext } from "vike/types";
@@ -30,6 +22,9 @@ async function onRenderHtml(pageContext: PageContext) {
     </PageContextProvider>
   ));
 
+  const favicon = pageContext.config.favicon;
+  const faviconTag = !favicon ? '' : escapeInject`<link rel="icon" href="${favicon}" />`;
+
   const { pipe } = renderToStream(() =>
     !pageContext.Page ? (
       <></> // the ssr config flag is false
@@ -47,6 +42,7 @@ async function onRenderHtml(pageContext: PageContext) {
       <head>
         <meta charset="UTF-8" />
         ${titleTag}
+        ${faviconTag}
         ${descriptionTag}
         ${dangerouslySkipEscape(headHtml)}
         ${dangerouslySkipEscape(generateHydrationScript())}