Add missing max overcommit factor to list of (dynamic) settings (elas…

…tic#83350) The setting node.bandwidth.recovery.operator.factor.max_overcommit wasn't added to the list of cluster settings and to the list of settings to consume for updates. Relates elastic#82819
vijay2308 · Feb 1, 2022 · 086c6e8 · 086c6e8
1 parent 5783412
commit 086c6e8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/docs/changelog/83350.yaml b/docs/changelog/83350.yaml
@@ -0,0 +1,5 @@
+pr: 83350
+summary: Add missing max overcommit factor to list of (dynamic) settings
+area: Recovery
+type: bug
+issues: []
diff --git a/server/src/main/java/org/elasticsearch/common/settings/ClusterSettings.java b/server/src/main/java/org/elasticsearch/common/settings/ClusterSettings.java
@@ -222,6 +222,7 @@ public void apply(Settings value, Settings current, Settings previous) {
         RecoverySettings.NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_SETTING,
         RecoverySettings.NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_READ_SETTING,
         RecoverySettings.NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_WRITE_SETTING,
+        RecoverySettings.NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_MAX_OVERCOMMIT_SETTING,
         RecoverySettings.NODE_BANDWIDTH_RECOVERY_DISK_WRITE_SETTING,
         RecoverySettings.NODE_BANDWIDTH_RECOVERY_DISK_READ_SETTING,
         RecoverySettings.NODE_BANDWIDTH_RECOVERY_NETWORK_SETTING,

diff --git a/server/src/main/java/org/elasticsearch/indices/recovery/RecoverySettings.java b/server/src/main/java/org/elasticsearch/indices/recovery/RecoverySettings.java
@@ -441,6 +441,7 @@ public RecoverySettings(Settings settings, ClusterSettings clusterSettings) {
                     NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_SETTING,
                     NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_READ_SETTING,
                     NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_WRITE_SETTING,
+                    NODE_BANDWIDTH_RECOVERY_OPERATOR_FACTOR_MAX_OVERCOMMIT_SETTING,
                     // non dynamic settings but they are used to update max bytes per sec
                     NODE_BANDWIDTH_RECOVERY_DISK_WRITE_SETTING,
                     NODE_BANDWIDTH_RECOVERY_DISK_READ_SETTING,