[#51] Header and footer #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nav has a max depth of 3 levels. This simplifies our markup since it doesn't have to be recursive
The desktop and mobile nav markup will be their own partials.
Instead of using a focus trap, we focus on the first element in the sub nav, but allow you to tab out of the list. When focus leaves, we pop the subnav.
joshuapease
force-pushed
the
jp/51-header-and-footer
branch
from
02e2624
to
528e251
Compare
joshuapease
commented
Oct 8, 2024
Comment on lines
+23
to
+36
| smd: { max: '639.98px' }, | ||
| sm: '640px', | ||
|
|
||
| mdd: { max: '749.98px' }, | ||
| md: '768px', | ||
|
|
||
| lgd: { max: '1023.98px' }, | ||
| lg: '1024px', | ||
|
|
||
| xld: { max: '1279.98px' }, | ||
| xl: '1280px', | ||
|
|
||
| '2xld': { max: '1535.98px' }, | ||
| '2xl': '1536px', |
There was a problem hiding this comment.
These are the default tailwind sizes, but also have a "down" variant that lets you select screens that are below a certain breakpoint's size.
Really helps when styles deviate a lot on mobile.
joshuapease
force-pushed
the
jp/51-header-and-footer
branch
from
528e251
to
d526e75
Compare
maxdmyers
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an accessible header, navigation and footer to the site starter.
Header & Navigation:
Front End
Accessibility / Focus Management
CleanShot.2024-10-07.at.15.23.56.mp4
Note
Intentionally using duplicate nav items so that the overlay will scroll.
CleanShot.2024-10-07.at.16.35.51-converted.mp4
Craft Admin
Footer
The footer is pretty basic, it includes a logo, links, and some placeholder copyright / privacy policy.
Craft Admin
The maximum depth is two. It uses the default field condig for Verbb navigation nodes.