Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Themes #24

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add Themes #24

wants to merge 13 commits into from

Conversation

puven12
Copy link
Contributor

@puven12 puven12 commented Mar 25, 2019

I wasn't able to separate each commits to single pull requests.

@jubalh
Copy link
Member

jubalh commented Mar 27, 2019

@puven12 you have several commits which do the same thing "Add 3024-Day theme" for example. You should squash such commits.

Also you need to create branches if you want to do several pull requests.

git checkout master
git checkout -b addOneTheme
...
git add ..
git commit
git push..
git checkout -b addAnotherTheme
...

Please read git documentation.

I'm not sure we need 3c081ce
@xaizek what do you think?

If we have this packagers should remove it from the vifm-colors package they build.

@xaizek
Copy link
Member

xaizek commented Mar 27, 2019

I'm not sure we need 3c081ce

It could be useful if it worked as expected (I have such directory), but git doesn't support all file types and things probably won't work on Windows (need admin rights to create symlinks...). Another option could be to provide a script that creates test directory on Unix-like systems, maybe not as a separate file, but in the README.

@puven12, there is https://githowto.com/ web-site which can teach you many things you need to know about git. It shouldn't take much time to go through all the steps.

@jubalh
Copy link
Member

jubalh commented Mar 27, 2019

Another option could be to provide a script that creates test directory on Unix-like systems, maybe not as a separate file, but in the README.

That's a good idea.
Maybe you want to try this @puven12 ?

@puven12
Copy link
Contributor Author

puven12 commented Mar 27, 2019

Thank you for the input guys. Yes i need to study git better. I followed Nodeschool's git-it workshop. Can you recommend me other hands-on ways to practise git?

@jubalh
Copy link
Member

jubalh commented Mar 27, 2019

Did you see the link @xaizek mentioned?
Also since you already create pull requests here I tried to give you the information you need to to improve your git knowledge. You created a PR something was not right and I mentioned it to you, so that you can google that part and experiment on your own how it works, then when you realize you still understand something not perfectly you try to find out what and formulate a question and google again.

@puven12
Copy link
Contributor Author

puven12 commented Mar 27, 2019

Yes I'm going through it. I learned how git works in real life projects like this one. Thank you again for being patient with my mistakes and letting me to contribute to this project. I will make sure to not repeat any more mistakes in the future. Sorry for messing up the project.
I will handle the task of making the script for the test.

@jubalh
Copy link
Member

jubalh commented Sep 23, 2020

@puven12 any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants