-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Themes #24
base: master
Are you sure you want to change the base?
Add Themes #24
Conversation
@puven12 you have several commits which do the same thing "Add 3024-Day theme" for example. You should squash such commits. Also you need to create branches if you want to do several pull requests.
Please read git documentation. I'm not sure we need 3c081ce If we have this packagers should remove it from the vifm-colors package they build. |
It could be useful if it worked as expected (I have such directory), but git doesn't support all file types and things probably won't work on Windows (need admin rights to create symlinks...). Another option could be to provide a script that creates test directory on Unix-like systems, maybe not as a separate file, but in the README. @puven12, there is https://githowto.com/ web-site which can teach you many things you need to know about git. It shouldn't take much time to go through all the steps. |
That's a good idea. |
Thank you for the input guys. Yes i need to study git better. I followed Nodeschool's git-it workshop. Can you recommend me other hands-on ways to practise git? |
Did you see the link @xaizek mentioned? |
Yes I'm going through it. I learned how git works in real life projects like this one. Thank you again for being patient with my mistakes and letting me to contribute to this project. I will make sure to not repeat any more mistakes in the future. Sorry for messing up the project. |
@puven12 any news? |
I wasn't able to separate each commits to single pull requests.