Skip to content

Commit

Permalink
[Security Solution] Fix flaky test for multiLineStringDiffAlgorithm (e…
Browse files Browse the repository at this point in the history
…lastic#205038)

**Fixes: elastic#205014

## Summary

This test on CI runs at least 10x slower than locally, and apparently
even 1000ms timeout is not enough.

Bumping it to 2000ms and hopefully that will be it. Not sure if it makes
sense to bump it even higher, because we need this threshold to be
reasonably low, and more than 2 seconds doesn't sound low for local test
runs.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
  • Loading branch information
banderror authored Dec 23, 2024
1 parent 29984c4 commit 8e0561a
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,11 @@ describe('multiLineStringDiffAlgorithm', () => {
const result = multiLineStringDiffAlgorithm(mockVersions);
const endTime = performance.now();

// If the regex merge in this function takes over 1 sec, this test fails
// If the regex merge in this function takes over 2 sec, this test fails
// Performance measurements: https://github.com/elastic/kibana/pull/199388
// NOTE: despite the fact that this test runs in ~50ms locally, on CI it
// runs slower and can be flaky even with a 500ms threshold.
expect(endTime - startTime).toBeLessThan(1000);
// runs ~10x slower and can be flaky even with a 1000ms threshold.
expect(endTime - startTime).toBeLessThan(2000);

expect(result).toEqual(
expect.objectContaining({
Expand Down

0 comments on commit 8e0561a

Please sign in to comment.