[Obs AI Assistant] Remove the copy button if there is no content to c…

…opy (elastic#196986)
viduni94 · Nov 5, 2024 · 37f7a7d · 37f7a7d
1 parent 7818ed2
commit 37f7a7d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/x-pack/packages/kbn-ai-assistant/src/chat/chat_item.tsx b/x-pack/packages/kbn-ai-assistant/src/chat/chat_item.tsx
@@ -99,7 +99,7 @@ export function ChatItem({
   const [editing, setEditing] = useState<boolean>(false);
   const [expanded, setExpanded] = useState<boolean>(Boolean(element));
 
-  const actions = [canCopy, collapsed, canCopy].filter(Boolean);
+  const actions = [canCopy, collapsed].filter(Boolean);
 
   const noBodyMessageClassName = css`
     ${moreCompactHeaderClassName}
@@ -179,11 +179,10 @@ export function ChatItem({
           onCopyToClipboard={handleCopyToClipboard}
           onToggleEdit={handleToggleEdit}
           onToggleExpand={handleToggleExpand}
-          content={content}
         />
       }
       className={
-        actions.length === 0 && !content
+        actions.length === 0 && !content && !element
           ? noPanelMessageClassName
           : collapsed
           ? noBodyMessageClassName

diff --git a/x-pack/packages/kbn-ai-assistant/src/chat/chat_item_actions.tsx b/x-pack/packages/kbn-ai-assistant/src/chat/chat_item_actions.tsx
@@ -8,7 +8,6 @@
 import React, { useEffect, useState } from 'react';
 import { i18n } from '@kbn/i18n';
 import { EuiButtonIcon, EuiPopover, EuiText } from '@elastic/eui';
-import type { Message } from '@kbn/observability-ai-assistant-plugin/common';
 
 export function ChatItemActions({
   canCopy,
@@ -19,7 +18,6 @@ export function ChatItemActions({
   onToggleEdit,
   onToggleExpand,
   onCopyToClipboard,
-  content,
 }: {
   canCopy: boolean;
   canEdit: boolean;
@@ -29,7 +27,6 @@ export function ChatItemActions({
   onToggleEdit: () => void;
   onToggleExpand: () => void;
   onCopyToClipboard: () => void;
-  content: Message['message']['content'];
 }) {
   const [isPopoverOpen, setIsPopoverOpen] = useState<string | undefined>();
 
@@ -73,7 +70,7 @@ export function ChatItemActions({
         />
       ) : null}
 
-      {canCopy && content ? (
+      {canCopy ? (
         <EuiPopover
           button={
             <EuiButtonIcon

diff --git a/x-pack/packages/kbn-ai-assistant/src/utils/get_timeline_items_from_conversation.tsx b/x-pack/packages/kbn-ai-assistant/src/utils/get_timeline_items_from_conversation.tsx
@@ -130,7 +130,6 @@ export function getTimelineItemsfromConversation({
 
       switch (role) {
         case MessageRole.User:
-          actions.canCopy = true;
           actions.canGiveFeedback = false;
           actions.canRegenerate = false;
 
@@ -210,11 +209,16 @@ export function getTimelineItemsfromConversation({
             display.collapsed = false;
           }
 
+          if (!content) {
+            actions.canCopy = false;
+          } else {
+            actions.canCopy = true;
+          }
+
           break;
 
         case MessageRole.Assistant:
           actions.canRegenerate = hasConnector;
-          actions.canCopy = true;
           actions.canGiveFeedback = true;
           display.hide = false;
 
@@ -250,6 +254,13 @@ export function getTimelineItemsfromConversation({
             display.collapsed = false;
             actions.canEdit = false;
           }
+
+          if (!content) {
+            actions.canCopy = false;
+          } else {
+            actions.canCopy = true;
+          }
+
           break;
       }