Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for chrome v53 #8386

Closed
wants to merge 1 commit into from
Closed

Conversation

wseymour15
Copy link
Contributor

@wseymour15 wseymour15 commented Aug 3, 2023

Description

Note: Dependent on the changes in videojs/videojs-generate-karma-config#44

This, along with the change in the karma config generator, adds an additional test suite for Chrome v53. We need this to ensure we test a viable version of chrome for SMART TVs.

Specific Changes proposed

  • Logic to use the older version of sinon when testing with Chrome v53
  • Adding that older sinon package to the test modules with an alias.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@@ -162,6 +162,7 @@
"shelljs": "^0.8.5",
"shx": "^0.3.2",
"sinon": "^11.1.1",
"sinon8": "npm:sinon@^8",
"typescript": "^4.8.4",
"uglify-js": "^3.6.0",
"unified": "^7.0.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we need to update the videojs-generate-karma-config version before this will work.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #8386 (63344f9) into main (3e9ef0a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8386   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         113      113           
  Lines        7578     7578           
  Branches     1821     1821           
=======================================
  Hits         6266     6266           
  Misses       1312     1312           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wseymour15 wseymour15 marked this pull request as draft August 3, 2023 20:30
@wseymour15
Copy link
Contributor Author

The plan is to reopen this PR once the Brightcove team has the time to finish up this work.

@wseymour15 wseymour15 closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant