Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for nepali language and a small typo fix for hindi language #8323

Merged

Conversation

ishwarrimal
Copy link
Contributor

Description

Enhancement: Added support for nepali language.

Specific Changes proposed

  • Added a new np.json file for nepali langauge.
  • Edited hi.json to update one key value.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jun 16, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@mister-ben mister-ben changed the title Support for nepali language and a small typo fix for hindi language feat: Support for nepali language and a small typo fix for hindi language Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f4aa91) 82.72% compared to head (baa78d5) 82.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8323   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         113      113           
  Lines        7594     7594           
  Branches     1827     1827           
=======================================
  Hits         6282     6282           
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Jun 29, 2023
@mister-ben mister-ben added minor This PR can be added to a minor release. It should not be added to a patch release. and removed needs: LGTM Needs one or more additional approvals labels Jul 4, 2023
@dzianis-dashkevich dzianis-dashkevich merged commit 4af7461 into videojs:main Dec 4, 2023
10 checks passed
Copy link

welcome bot commented Dec 4, 2023

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants