-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): improves quality of typescript definitions #8218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8218 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 113 113
Lines 7578 7578
Branches 1821 1821
=======================================
Hits 6266 6266
Misses 1312 1312
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
reviewed
Mar 29, 2023
This fixes this error:
diff --git a/src/js/video.js b/src/js/video.js
index d271362c..1602fd71 100644
--- a/src/js/video.js
+++ b/src/js/video.js
@@ -2,7 +2,7 @@
* @file video.js
* @module videojs
*/
-import {version} from '../../package.json';
+import {version as pkgVersion} from '../../package.json';
import window from 'global/window';
import {
hooks_,
@@ -37,6 +37,13 @@ import xhr from '@videojs/xhr';
import Tech from './tech/tech.js';
import { use as middlewareUse, TERMINATOR } from './tech/middleware.js';
+/**
+ * Current Video.js version. Follows [semantic versioning](https://semver.org/).
+ *
+ * @type {string}
+ */
+const version = pkgVersion;
+
/**
* Normalize an `id` value by trimming off a leading `#`
* Can this change be added to this PR too? This is what gets added to /**
* Current Video.js version. Follows [semantic versioning](https://semver.org/).
*
* @type {string}
*/
declare const version: string; |
mister-ben
reviewed
May 14, 2023
Can't figure out why the tests fail here... |
mister-ben
approved these changes
Aug 11, 2023
7 tasks
mister-ben
changed the title
feat(types): improves quality of typescript definitions
fix(types): improves quality of typescript definitions
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR squashes a few tsc errors and improves typescript definitions.
Requirements Checklist