Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust network manager api #35

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

dzianis-dashkevich
Copy link
Collaborator

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chrome, Firefox, Safari, Edge) (if applicable)
  • Unit Tests updated or fixed (if applicable)
  • Docs/guides updated (if applicable)

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for videojsdev ready!

Name Link
🔨 Latest commit 56ec9f0
🔍 Latest deploy log https://app.netlify.com/sites/videojsdev/deploys/67204af1adc1970008868b61
😎 Deploy Preview https://deploy-preview-35--videojsdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dzianis-dashkevich dzianis-dashkevich merged commit da5e546 into main Oct 29, 2024
8 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the adjust-network-manager-api branch October 29, 2024 03:42
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 42.03540% with 131 lines in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (f55db3e) to head (56ec9f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...back/src/lib/player/worker-thread/worker-bridge.ts 0.00% 67 Missing ⚠️
...ckages/playback/src/lib/player/base/base-player.ts 32.25% 42 Missing ⚠️
...ckages/playback/src/lib/network/network-manager.ts 42.85% 12 Missing ⚠️
packages/playback/src/lib/events/player-events.ts 57.14% 6 Missing ⚠️
...ckages/playback/src/lib/network/network-request.ts 93.75% 3 Missing ⚠️
...ges/playback/src/lib/utils/interceptors-storage.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   68.06%   66.89%   -1.18%     
==========================================
  Files         103      103              
  Lines        3961     4147     +186     
  Branches      576      574       -2     
==========================================
+ Hits         2696     2774      +78     
- Misses       1252     1362     +110     
+ Partials       13       11       -2     
Flag Coverage Δ
dash-parser 66.89% <42.03%> (-1.18%) ⬇️
env-capabilities 66.89% <42.03%> (-1.18%) ⬇️
hls-parser 66.89% <42.03%> (-1.18%) ⬇️
playback 66.89% <42.03%> (-1.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant