Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for worker split #33

Merged
merged 17 commits into from
Oct 24, 2024
Merged

Prepare for worker split #33

merged 17 commits into from
Oct 24, 2024

Conversation

dzianis-dashkevich
Copy link
Collaborator

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chrome, Firefox, Safari, Edge) (if applicable)
  • Unit Tests updated or fixed (if applicable)
  • Docs/guides updated (if applicable)

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for videojsdev ready!

Name Link
🔨 Latest commit 65010a5
🔍 Latest deploy log https://app.netlify.com/sites/videojsdev/deploys/671995937fca880008b57f3c
😎 Deploy Preview https://deploy-preview-33--videojsdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dzianis-dashkevich dzianis-dashkevich changed the title WIP: Prepare for worker split Prepare for worker split Oct 24, 2024
@dzianis-dashkevich dzianis-dashkevich marked this pull request as ready for review October 24, 2024 00:32
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 54.14710% with 293 lines in your changes missing coverage. Please review.

Project coverage is 68.06%. Comparing base (fa54860) to head (65010a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/playback/src/lib/player/base/base-player.ts 21.50% 73 Missing ⚠️
...back/src/lib/player/worker-thread/player-worker.ts 0.00% 64 Missing and 1 partial ⚠️
...back/src/lib/player/worker-thread/worker-bridge.ts 0.00% 39 Missing and 1 partial ⚠️
.../worker-thread/messages/main-to-worker-messages.ts 0.00% 27 Missing and 1 partial ⚠️
...lib/player/base/pipeline-loader-factory-storage.ts 27.27% 24 Missing ⚠️
.../worker-thread/messages/worker-to-main-messages.ts 0.00% 21 Missing and 1 partial ⚠️
...kages/env-capabilities/src/lib/env-capabilities.ts 94.60% 13 Missing ⚠️
...ges/playback/src/lib/utils/interceptors-storage.ts 48.00% 13 Missing ⚠️
...orker-thread/consts/main-to-worker-message-type.ts 0.00% 4 Missing and 1 partial ⚠️
...orker-thread/consts/worker-to-main-message-type.ts 0.00% 2 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   72.56%   68.06%   -4.50%     
==========================================
  Files          87      103      +16     
  Lines        3867     3961      +94     
  Branches      552      576      +24     
==========================================
- Hits         2806     2696     -110     
- Misses       1058     1252     +194     
- Partials        3       13      +10     
Flag Coverage Δ
dash-parser 68.06% <54.14%> (-4.50%) ⬇️
env-capabilities 68.06% <54.14%> (?)
hls-parser 68.06% <54.14%> (-4.50%) ⬇️
playback 68.06% <54.14%> (-4.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich dzianis-dashkevich merged commit 1fd5933 into main Oct 24, 2024
7 of 9 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the prepare-for-worker-split branch October 24, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant