chore: test

videojs · Oct 17, 2024 · 1b46f05 · 1b46f05
1 parent 1d1427e
commit 1b46f05
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/vtt-segment-loader.js b/src/vtt-segment-loader.js
@@ -383,8 +383,10 @@ export default class VTTSegmentLoader extends SegmentLoader {
   }
 
   handleData_(simpleSegment, result) {
+    const isFmp4VttSegment = simpleSegment.type === 'vtt' && result.type === 'text';
     // handle segment data for fmp4 encapsulated webvtt
-    if (simpleSegment.type === 'vtt') {
+
+    if (isFmp4VttSegment) {
       super.handleData_(simpleSegment, result);
     }
   }

diff --git a/test/vtt-segment-loader.test.js b/test/vtt-segment-loader.test.js
@@ -1005,7 +1005,7 @@ QUnit.module('VTTSegmentLoader', function(hooks) {
       assert.equal(mockSegmentInfo.cues[0].endTime, 3, 'startTime is correct value');
     });
 
-    QUnit.test('parseMp4VttCues_ adds parsed mp4VttCues to the segmentInfo object', function(assert) {
+    QUnit.test('parseMp4VttCues_ adds parsed mp4VttCues to the segmentInfo object using audioTimestamp', function(assert) {
       const mockSegmentInfo = {
         mp4VttCues: [{
           start: 1,
@@ -1030,5 +1030,23 @@ QUnit.module('VTTSegmentLoader', function(hooks) {
       assert.equal(mockSegmentInfo.cues[0].startTime, 1, 'startTime is correct value');
       assert.equal(mockSegmentInfo.cues[0].endTime, 3, 'startTime is correct value');
     });
+
+    QUnit.test('handleData_ passes fmp4 vtt segment data to parent loader', function(assert) {
+      const done = assert.async();
+      const mockSimpleSegment = {
+        type: 'vtt',
+        stats: 'fake.stats'
+      };
+      const mockResult = {
+        type: 'text'
+      };
+
+      // mock this function to spy the super handleData call.
+      loader.earlyAbortWhenNeeded_ = (stats) => {
+        assert.equal(stats, 'fake.stats', 'expected stats value is passed.');
+        done();
+      };
+      loader.handleData_(mockSimpleSegment, mockResult);
+    });
   });
 });