Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lvmasterrj fixes #443

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Lvmasterrj fixes #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
162aa3d
fix: Notification not being shown using Flask Flash
lvmasterrj Dec 3, 2024
79c4000
fix: File was being deleted even if it was in queue
lvmasterrj Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pikaraoke/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,8 @@ def start_song():
def delete_file():
if "song" in request.args:
song_path = request.args["song"]
if song_path in k.queue:
exists = any(item.get('file') == song_path for item in k.queue)
if exists:
flash(
"Error: Can't delete this song because it is in the current queue: " + song_path,
"is-danger",
Expand Down
2 changes: 1 addition & 1 deletion pikaraoke/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@

{% if get_flashed_messages() %}
{% for category, message in get_flashed_messages(with_categories=true) %}
<div id="notification" class="notification {{category}}" style="display: none">
<div id="notification" class="notification {{category}}">
<button id="notification-close" class="delete"></button>
<div class="flash">{{ message }}</div>
</div>
Expand Down
Loading