Code Quality in CI #360
Code Quality in CI #360
Conversation
mariugul
force-pushed
the
chore/code-quality
branch
from
b6bca17 to
a5f5143
Compare
mariugul
force-pushed
the
chore/code-quality
branch
from
a5f5143 to
7efe891
Compare
This formatted python files with isort, black and ran pylint linter. It checked newlines at the end of files. Formatted html, css, js. Formatted Markdown and txt files. Checked the shell scripts for shebangs.
No need to track private vs code settings.json in git.
|
I was thinking that the CI will of course run as fail, because I only introduced the CI and I didn't format the files. So I pushed a commit to this PR where I formatted all the files by running the |
|
@vicwomg I can continue scoping out PR's once this is merged. Whenever you have the time to review it. |
Apologies, I have been traveling and have returned. Will be able to dedicate more time to this in the next few days |
No worries! |
Code Quality
Introduced linting and formatting of the code. Used the most common tools from pre-commit and ran it on all the files. This is black formatter, isort import formatter, pylint, yaml, markdown formatters, unused imports ++. This is a
cherry-pickfrom #359 + a commit to introduce the code quality to CI.CI
Added a simple workflow to run this in CI on PR's. Haven't been able to test the CI run. T
Locally
hese code quality tools can also be run locally by adding it as a pre-commit hook or just running it manually.