-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default delete delay #402
base: master
Are you sure you want to change the base?
Conversation
The default delay of 1000 ms was outdated and being rate limited with the old default delay has been inevitable for a while.
I can confirm still getting rate limited with this change. Increasing to 4500 seems to help… |
Are you testing this with your own messages or other users' messages? |
Other users’ messages for what it’s worth. |
It does change the situation quite a bit as you get rate limited a lot more strictly when deleting others' messages. The new default value here takes into account only wiping your own messages. Could make the system adapt to which of those you chose. |
I think that would make the most sense. It seems a simple change to compare the entered user id value to the current user's, then change the default delay value to 4500 (which seems the sweet spot from my somewhat limited testing). |
The default delay of 1000 ms was outdated and being rate limited with the old default delay has been inevitable for a while.
This PR updates the default delay to 2500 ms to prevent getting rate limited.