Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default delete delay #402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update default delete delay #402

wants to merge 2 commits into from

Conversation

abigailwillow
Copy link
Contributor

@abigailwillow abigailwillow commented Jul 22, 2022

The default delay of 1000 ms was outdated and being rate limited with the old default delay has been inevitable for a while.

This PR updates the default delay to 2500 ms to prevent getting rate limited.

Abigail de Joode added 2 commits July 23, 2022 01:37
The default delay of 1000 ms was outdated and being rate limited with the old default delay has been inevitable for a while.
@abigailwillow abigailwillow mentioned this pull request Sep 27, 2022
@jet082
Copy link

jet082 commented Oct 7, 2022

I can confirm still getting rate limited with this change. Increasing to 4500 seems to help…

@abigailwillow
Copy link
Contributor Author

I can confirm still getting rate limited with this change. Increasing to 4500 seems to help…

Are you testing this with your own messages or other users' messages?

@jet082
Copy link

jet082 commented Oct 7, 2022

I can confirm still getting rate limited with this change. Increasing to 4500 seems to help…

Are you testing this with your own messages or other users' messages?

Other users’ messages for what it’s worth.

@abigailwillow
Copy link
Contributor Author

abigailwillow commented Oct 7, 2022

Other users’ messages for what it’s worth.

It does change the situation quite a bit as you get rate limited a lot more strictly when deleting others' messages. The new default value here takes into account only wiping your own messages. Could make the system adapt to which of those you chose.

@jet082
Copy link

jet082 commented Oct 7, 2022

Other users’ messages for what it’s worth.

It does change things as you get rate limited a lot more strictly when deleting others' messages. The new default value here takes into account only wiping your own messages. Could make the system adapt to which of those you chose.

I think that would make the most sense. It seems a simple change to compare the entered user id value to the current user's, then change the default delay value to 4500 (which seems the sweet spot from my somewhat limited testing).

@abigailwillow abigailwillow closed this by deleting the head repository Feb 19, 2023
@abigailwillow abigailwillow reopened this Feb 22, 2023
@victornpb victornpb added the PR missing src files (can't merge) Doesn't contain changes to src files. (Please read CONTRIBUTING) label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR missing src files (can't merge) Doesn't contain changes to src files. (Please read CONTRIBUTING)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants