Update on python API to correct undefined references #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the migration to the new C API the python module stop working as expected. A few errors appear after import: undefined functions (Layer_Init, Material_Init, Material_InitTensor, Simulation_AddMaterial, Simulation_GetPoyntingFlux and Simulation_MakeExcitationExterior) and the SetFrequency stop detroying the previous results. All these dependencies to the old API have been corrected by upgrading to the new C API when possible.
Patched S4Sim_SetRegionCircle file
|
Works like a charm! Thanks so much for making these corrections. |
|
@kwrobert After sending the pull request I noticed that some of functions which still use the old API are not working properly. For example, I fixed |
The update of the python API is complete for regions. Apparently, everything is working. The only difference between these results and those of ca2b90 commit are when the region has an angle different from zero. Changes in pattern.c are to make it compliant with SuiteSparse. The make related files are forced to use the system gcc for compilation and linking.
The kwlist of the python API is compatible with the old version. S4_Layer and S4_Material are changed to Layer and Material.
|
I get a |
Commented the ENABLE_S4_TRACE option, which is useful for debugging purposes.
Binaries removed from index and ENABLE_S4_TRACE removed as default option in Makefile.ubuntu.
This branch uses the new S4 python API which turns out to be very unstable. To coexists both modules, the name of the module in this branch changed from S4 to S42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the migration to the new C API the python module stop working as expected. A few errors appear after import:
Layer_Init,Material_Init,Material_InitTensor,Simulation_AddMaterial,Simulation_GetPoyntingFluxandSimulation_MakeExcitationExteriorSetFrequencystop detroying previous results.All these dependencies to the old API have been corrected by upgrading to the new C API when possible.
Old API calls still remains, although the python extension is more useful that the current version.