fix: addressing reviews

vibhatha · May 29, 2024 · af836b1 · af836b1
1 parent 3b982a4
commit af836b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java
@@ -27,7 +27,6 @@
 import java.util.Calendar;
 import java.util.HashMap;
 import java.util.Locale;
-import java.util.Objects;
 import java.util.TimeZone;
 
 import org.apache.arrow.memory.BufferAllocator;
@@ -90,17 +89,17 @@ public void testConfig() {
     JdbcToArrowConfigBuilder builder = new JdbcToArrowConfigBuilder(allocator, calendar);
     JdbcToArrowConfig config = builder.build();
 
-    assertTrue(Objects.equals(allocator, config.getAllocator()));
-    assertTrue(Objects.equals(calendar, config.getCalendar()));
+    assertEquals(allocator, config.getAllocator());
+    assertEquals(calendar, config.getCalendar());
 
     Calendar newCalendar = Calendar.getInstance();
     BufferAllocator newAllocator = new RootAllocator(Integer.SIZE);
 
     builder.setAllocator(newAllocator).setCalendar(newCalendar);
     config = builder.build();
 
-    assertTrue(Objects.equals(newAllocator, config.getAllocator()));
-    assertTrue(Objects.equals(newCalendar, config.getCalendar()));
+    assertEquals(newAllocator, config.getAllocator());
+    assertEquals(newCalendar, config.getCalendar());
   }
 
   @Test

diff --git a/java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestBaseAllocator.java b/java/memory/memory-core/src/test/java/org/apache/arrow/memory/TestBaseAllocator.java
@@ -1077,6 +1077,8 @@ public void testMemoryLeakWithReservation() throws Exception {
           "child2", 1024, MAX_ALLOCATION);
       rootAllocator.verify();
 
+      childAllocator2.buffer(256);
+
       Exception exception = assertThrows(IllegalStateException.class, () -> {
         childAllocator2.close();
       });