Improve timer performance #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that pointers to slots stay valid, allowing to avoid the m_timers map in the future.
Uses timer slot pointers directly as IDs. The validation counter field is used to ensure that stale timer IDs do not affect reused timer slots.
Leads to heavy performance improvements in various scenarios involving many timers, partially benefiting from the hierarchical nature of the timing wheels structure and partially by avoiding the quadratic asymptotic run time of the timer queue approach (for each timer, the queue needs to be traversed linearly to find the insertion place).
s-ludwig
force-pushed
the
timing_wheels
branch
from
222c3e5
to
682ea0c
Compare
l-kramer
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes any GC allocations from the timer module and employs a hierarchical timing wheels based approach to ensure a timer performance doesn't degrade excessively when large numbers of timers are active. When many concurrent timeouts or
sleeps are involved, this can lead to tenfold improvements in required CPU time.