Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP upgrade to scala 3 #759

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from
Draft

WIP upgrade to scala 3 #759

wants to merge 25 commits into from

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Aug 8, 2024 •
edited
Loading

Describe your changes

fix a range of issues until it compiles.
This won't work though, too much stuff bypassed.

Related issue(s)

Closes #715

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@Grifs
Disable any reflection & circe calls as it was tripping over its toes
d19a0d3 
fix a range of issues until it compiles.
This won't work though, too much stuff bypassed.
@Grifs Grifs changed the title Disable any reflection & circe calls as it was tripping over its toes WIP upgrade to scala 3 Aug 8, 2024
@Grifs
Copy link
Collaborator Author

Grifs commented Aug 30, 2024 •
edited
Loading

  • Fix syntax changes & compile errors
  • Disable exporting functionality as needed to disable old reflection code + circe because interface changed drastically
  • Fix Circe code to use basic decoders & encoders
    • Use base decoders by adding some dummy wrapper calls
    • Use configuration
    • Fix explicitely having to import decoders
    • Re-enable conversion code & error checks
    • Get full history of failing encoder
  • Re-implement reflection
    • checks in circe
    • cli-schema / cli-autocomplete
    • config-schema / json-schema
    • Solve stripMargin in annotations

@Grifs
Re-enable code & provide temporary methods as needed. Further cleanup
b008154
@Grifs
minor cleanup
664a782
@Grifs
fix temporary code still being present
dfdf294 
fix platforms being able to encode
fix executablerunner not using the correct encoder

other small cleanup
@Grifs
Tweak how the encoder & decoder placeholders are formatted
ef49859
@Grifs
remove all stripMargins from field case class annotations
25891ca 
To be solved later by either fixing the recursion that is happening or by the reflection code to call stripMargin on the fields.
TBD, but the second solution could potentially cleanup some of the annotation code.
@Grifs
Add custom encoder & decoder for Status enum
9ed9d94 
Manually written code, I bet there is a better way
@Grifs
Add back some validation code to assist with invalid fields
b299ac9 
Temporary way of getting the class name
Not fetching the valid fields yet
@Grifs
provide safeguard to solve empty packageconfig issues
3e9da39
@Grifs
Start using reflection to get class name and fields
83aaaee 
Mark regex issues as unchecked to be solved later
@Grifs
reactivate some code
8d422d0
@Grifs
fix broken indentation
e39672c
@Grifs
Start progressing to Circe to use mirroring directly instead of going…
fd79c50 
… through the schemas super-classes
@Grifs
Add implementation of fieldsInternalFunctionality
4fde75b 
Add some minor type annotations in CollectedSchemas, which will refactoring easier because we'll now know what was previously expected
@Grifs
add deprecation & removal annotation code
f7e2d0b 
seems likely that the code can be streamlined a bit more, tbd
@Grifs
Refactor mirror method names
ba38803
@Grifs
Fix empty package configs failing as it gets parsed as false
0d98639
@Grifs
rename niceNameOf to typeOf and improve output of e.g. List[String]
7d84d7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Grifs