Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add falco and multiqc. #8

Merged
merged 14 commits into from
May 14, 2024
Merged

FEAT: Add falco and multiqc. #8

merged 14 commits into from
May 14, 2024

Conversation

DriesSchaumont
Copy link
Contributor

No description provided.

@DriesSchaumont DriesSchaumont requested a review from tverbeiren May 3, 2024 07:17
@tverbeiren
Copy link
Contributor

I suggest to split the two blocks of groovy code off in two separate workflows, something like split_samples_and_validate and combine_samples.

@DriesSchaumont DriesSchaumont changed the title FEAT: Add falco. FEAT: Add falco and multiqc. May 7, 2024
@DriesSchaumont
Copy link
Contributor Author

I suggest to split the two blocks of groovy code off in two separate workflows, something like split_samples_and_validate and combine_samples.

Done! I also added multiqc in the meantime ⏩

@tverbeiren
Copy link
Contributor

Looks good!

My suggestion would be to put the spun off workflows in their separate 'component' like for instance https://viash-hub.com/data-intuitive/vsh-pipeline-operators/-/tree/main/src/split/vsh_flatten?ref_type=heads.

@DriesSchaumont
Copy link
Contributor Author

Looks good!

My suggestion would be to put the spun off workflows in their separate 'component' like for instance https://viash-hub.com/data-intuitive/vsh-pipeline-operators/-/tree/main/src/split/vsh_flatten?ref_type=heads.

I'm not sure that the current workflow got simpler by doing this. But once more functionality is added I think it will have been beneficial ✅

@tverbeiren
Copy link
Contributor

Looks good!

@DriesSchaumont DriesSchaumont merged commit fb98dc5 into main May 14, 2024
1 check passed
@DriesSchaumont DriesSchaumont deleted the feat/add_falco branch May 29, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tverbeiren tverbeiren tverbeiren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DriesSchaumont @tverbeiren