FastQC

[tgaspe]

Description

Creating FastQC component.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

• I have performed a self-review of my code

• Conforms to the Contributing guidelines

• Proposed changes are described in the CHANGELOG.md

• I have tested my code with viash ns test --parallel -q <name or namespace>

• Check the correct box. Does this PR contain:

  • Breaking changes
  • New functionality
  • Major changes
  • Minor changes
  • Documentation
  • Bug fixes

[rcannood]

ci tests are failing (but error is not caught properly). Can you take a look?

[tgaspe]

Hi Robrecht,

I am not sure I understand which tests are failing?

[rcannood]

Hi Robrecht,

I am not sure I understand which tests are failing?

Check the log for the following:

...be treated as a positional argument. Use --help to get more information on the parameters.
/tmp/viash-run-fastqc-v6dfhC.sh: line 54: run: command not found

[tgaspe]

I see, thanks.

[rcannood]

minor comments

[rcannood]

Looking through the code again, I found some issues that need to be dealt with. Let me know whether my comments are clear enough.

[rcannood]

LGTM!