Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/no ref/add bowtie2 #73

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Feature/no ref/add bowtie2 #73

wants to merge 7 commits into from

Conversation

tverbeiren
Copy link
Contributor

Description

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

rcannood
rcannood requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There are some unicode characters in the config. Could we remove these?
  • The test files are quite large. Can we subset them or generate them on the fly?

Thanks!

@rcannood
Copy link
Contributor

rcannood commented Aug 8, 2024

@KaiWaldrant can you review my comments?

@KaiWaldrant KaiWaldrant marked this pull request as draft September 27, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tverbeiren @rcannood @KaiWaldrant