Add star solo component #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSchaumont
requested changes
Jul 5, 2024
| multiple: yes | ||
| multiple_sep: ; | ||
| - name: --soloCBstart | ||
| type: integer |
There was a problem hiding this comment.
Should we add min and/or max for the arguments of type: integer where applicable?
There was a problem hiding this comment.
Could be done but I don't really want to start parsing this from the help text. I propose hoping that STAR has sufficiently good validation?
src/star/star_solo/test.sh
Outdated
| @@ -0,0 +1,176 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
|
@DriesSchaumont I'm strongly considering dropping the star solo component and just adding the missing arguments to the main star_align_reads component. WDYT? |
Yes, I agree... Its complicated already ^^ |
|
Done! @DriesSchaumont Care to re-review? |
DriesSchaumont
approved these changes
Jul 29, 2024
Co-authored-by: Dries Schaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGES
star/star_align_reads: Change all arguments from--camelCaseto--snake_case(PR Add star solo component #62).star/star_genome_generate: Change all arguments from--camelCaseto--snake_case(PR Add star solo component #62).NEW FUNCTIONALITY
star/star_align_reads: Add star solo related arguments (PR Add star solo component #62).Issue ticket number
Closes #xxxx
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributing guidelines
Proposed changes are described in the CHANGELOG.md
I have tested my code with
viash ns test --parallel -q <name or namespace>Check the correct box. Does this PR contain: