Add bgzip #4
Merged
Add bgzip #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
reviewed
Jan 23, 2024
rcannood
approved these changes
Jan 30, 2024
rcannood
requested changes
Jan 30, 2024
| setup: | ||
| - type: docker | ||
| run: | | ||
| bgzip -h | grep 'Version:' 2>&1 | sed 's/Version:\s\(.*\)/arriba: "\1"/' > /var/software_versions.txt |
There was a problem hiding this comment.
Suggested change
| bgzip -h | grep 'Version:' 2>&1 | sed 's/Version:\s\(.*\)/arriba: "\1"/' > /var/software_versions.txt | |
| bgzip -h | grep 'Version:' 2>&1 | sed 's/Version:\s\(.*\)/bgzip: "\1"/' > /var/software_versions.txt |
Please verify that this indeed returns the expected format
There was a problem hiding this comment.
docker run -it --entrypoint cat bgzip:latest /var/software_versions.txt
bgzip: "1.19"
There was a problem hiding this comment.
Please turn this into a script.sh file in line with the test data script in other components. Also remove any mentions of arriba.
There was a problem hiding this comment.
I missed that the expected file was changed. I like it much better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an implementaiton for bgzip inspired by snakemake-wrappers
Issue ticket number
Closes #xxxx
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributing guidelines
Proposed changes are described in the CHANGELOG.md
I have tested my code with
viash ns test --parallel -q <name or namespace>Check the correct box. Does this PR contain: