Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix featurecounts #20

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Fix featurecounts #20

merged 3 commits into from
Feb 7, 2024

Conversation

sainirmayi
Copy link
Contributor

@sainirmayi sainirmayi commented Feb 7, 2024

Description

Fix to run featurecounts without junctions argument.
Add test case without junctions argument.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

Sorry, something went wrong.

@sainirmayi sainirmayi requested a review from rcannood February 7, 2024 09:04
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcannood rcannood merged commit 487c5d2 into main Feb 7, 2024
6 checks passed
@rcannood rcannood deleted the fix_featurecounts branch February 7, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants