Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kallisto quant #152

Merged
merged 16 commits into from
Sep 19, 2024
Merged

Kallisto quant #152

merged 16 commits into from
Sep 19, 2024

Conversation

emmarousseau
Copy link
Collaborator

@emmarousseau emmarousseau commented Sep 15, 2024

Description

Add kallisto_quant

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@emmarousseau emmarousseau marked this pull request as ready for review September 15, 2024 09:55
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing, but I can already give you these comments

CHANGELOG.md Outdated Show resolved Hide resolved
src/kallisto/kallisto_quant/config.vsh.yaml Outdated Show resolved Hide resolved
src/kallisto/kallisto_quant/config.vsh.yaml Outdated Show resolved Hide resolved
@rcannood
Copy link
Contributor

LGTM! Thanks @emmarousseau !

@rcannood rcannood merged commit bc9cc0a into viash-hub:main Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants