Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Make output quant file an optional argument #151

Merged
merged 1 commit into from
Sep 13, 2024
Merged

FIX: Make output quant file an optional argument #151

merged 1 commit into from
Sep 13, 2024

Conversation

sainirmayi
Copy link
Contributor

@sainirmayi sainirmayi commented Sep 12, 2024 •
edited
Loading

Description

The output file quant.sf is not generated when salmon quant is run with the --skipQuant flag, so quant_results should be an optional output argument.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@sainirmayi sainirmayi merged commit fe56ee7 into main Sep 13, 2024
2 checks passed
@sainirmayi sainirmayi deleted the salmon_quant_fix branch September 13, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tverbeiren tverbeiren tverbeiren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainirmayi @tverbeiren