Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umitools prepare for rsem #148

Merged
merged 14 commits into from
Sep 13, 2024

Conversation

emmarousseau
Copy link
Collaborator

Description

Add prepare-for-rsem UMItools component

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@tverbeiren tverbeiren self-requested a review September 6, 2024 22:02
Copy link
Contributor

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see code comments.

CHANGELOG.md Outdated Show resolved Hide resolved
src/umi_tools/umi_tools_prepareforrsem/config.vsh.yaml Outdated Show resolved Hide resolved
src/umi_tools/umi_tools_prepareforrsem/test.sh Outdated Show resolved Hide resolved
@tverbeiren
Copy link
Contributor

The Python script has an undocumented argument for retrieving the version:

    parser = U.OptionParser(version="%prog version: $Id$", usage=usage, description=globals()["__doc__"])

I suggest you use that for version instead of the pip dependencies.

@tverbeiren
Copy link
Contributor

The name of the component is different in the CHANGELOG and the config.vsh.yaml, please align.

@tverbeiren
Copy link
Contributor

One more thing: please move the samtools installation in the test.sh script to the beginning of the test script so the output does not interfere with the output of the tests themselves.

@emmarousseau
Copy link
Collaborator Author

emmarousseau commented Sep 11, 2024

Nirmayi pointed out the you can use the prepare-for-rsem command directly instead of calling the python script, but the version argument for that tools specifically does not work (at least for me, output below), so I included the general umi_tools version.

umi_tools prepare-for-rsem --version 
# prepare-for-rsem version: $Id$

@tverbeiren tverbeiren merged commit 3f6a1b5 into viash-hub:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants