Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fq subsample #147

Merged
merged 14 commits into from
Sep 9, 2024
Merged

Fq subsample #147

merged 14 commits into from
Sep 9, 2024

Conversation

emmarousseau
Copy link
Collaborator

Description

Add fq_subsample component

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@tverbeiren
Copy link
Contributor

This PR looks good, I don't have any comments except for the size of the container (2.5G). It can be reduced to half of that by using a config like this:

engines:
  - type: docker
    image: rust:1.81-slim
    setup: 
      - type: docker
        run: |
          apt-get update && apt-get install -y git procps && \
          git clone --depth 1 --branch v0.12.0 https://github.com/stjude-rust-labs/fq.git && \
          cd fq && \
          cargo install --locked --path . && \
          mv target/release/fq /usr/local/bin/ && \
          cd / && rm -rf /fq

@tverbeiren tverbeiren self-requested a review September 6, 2024 14:46
Copy link
Contributor

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment about the docker container setup.

@tverbeiren tverbeiren merged commit 9f81386 into viash-hub:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants