-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fq subsample #147
Merged
Merged
Fq subsample #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 38f586b.
This PR looks good, I don't have any comments except for the size of the container (2.5G). It can be reduced to half of that by using a config like this: engines:
- type: docker
image: rust:1.81-slim
setup:
- type: docker
run: |
apt-get update && apt-get install -y git procps && \
git clone --depth 1 --branch v0.12.0 https://github.com/stjude-rust-labs/fq.git && \
cd fq && \
cargo install --locked --path . && \
mv target/release/fq /usr/local/bin/ && \
cd / && rm -rf /fq
|
tverbeiren
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment about the docker container setup.
tverbeiren
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fq_subsample component
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributing guidelines
Proposed changes are described in the CHANGELOG.md
I have tested my code with
viash ns test --parallel -q <name or namespace>
Check the correct box. Does this PR contain: