Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortmerna #146

Merged
merged 15 commits into from
Sep 9, 2024
Merged

Sortmerna #146

merged 15 commits into from
Sep 9, 2024

Conversation

emmarousseau
Copy link
Collaborator

Description

Add sortMeRNA component

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@emmarousseau emmarousseau marked this pull request as ready for review September 1, 2024 19:28
@tverbeiren tverbeiren self-requested a review September 6, 2024 21:49
tverbeiren
tverbeiren requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@tverbeiren tverbeiren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component looks complete and functional.

I'd like to see a few more test scenarios though, especially for the parameters that require specific parsing logic: --ribo_database_manifest and --ref.

@emmarousseau
Copy link
Collaborator Author

Let me know if these are enough!

tverbeiren
tverbeiren approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tverbeiren tverbeiren merged commit 320d044 into viash-hub:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tverbeiren tverbeiren tverbeiren approved these changes

@rcannood rcannood Awaiting requested review from rcannood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmarousseau @tverbeiren