Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agat sp complement annotations #129

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Aug 7, 2024

Description

  • Added agat_sp_complement_annotations
  • Handled argument with multiple=true

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011 Leila011 marked this pull request as ready for review August 7, 2024 15:13
@Leila011 Leila011 assigned Leila011 and unassigned Leila011 Aug 7, 2024
@Leila011 Leila011 requested a review from rcannood August 7, 2024 15:14
@Leila011 Leila011 requested review from dorien-er and removed request for rcannood August 8, 2024 07:30
issue_tracker: https://github.com/NBISweden/AGAT/issues
repository: https://github.com/NBISweden/AGAT
references:
doi: 10.5281/zenodo.3552717
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doi: 10.5281/zenodo.3552717
https://doi.org/10.5281/zenodo.3552717

means all of them are kept.
type: integer
required: false
example: 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
example: 100
example: 100
min: 0

* A l1 feature from the addfile.gff with a CDS that overlaps a l1 feature with a CDS from the reference annotation will be added only if the CDSs don't overlap.
* A l1 feature from the addfile.gff without a CDS that overlaps a l1 feature without a CDS from the reference annotation will be added only if none of the l3 features overlap.

! It is sufficient that only one isoform is overlapping to prevent the whole gene (l1 feature) from the addfile.gff to be added in the output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
! It is sufficient that only one isoform is overlapping to prevent the whole gene (l1 feature) from the addfile.gff to be added in the output.
It is sufficient that only one isoform is overlapping to prevent the whole gene (l1 feature) from the addfile.gff to be added in the output.

Comment on lines +40 to +45
Annotation(s) file you would like to use to complement the
reference annotation. You can specify as much file you want like.
The order you provide these files matter. Once the reference file has been
complemented by file1, this new annotation becomes the new
reference that will be complemented by file2 etc.
So, be aware of what you want if you use several addfiles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Annotation(s) file you would like to use to complement the
reference annotation. You can specify as much file you want like.
The order you provide these files matter. Once the reference file has been
complemented by file1, this new annotation becomes the new
reference that will be complemented by file2 etc.
So, be aware of what you want if you use several addfiles.
Annotation file(s) you would like to use to complement the reference annotation. You can specify as many files as you like. The order you provide these files matter. Once the reference file has been complemented by file1, this new annotation becomes the new reference that will be complemented by file2, etc. So, be aware of what you want if you use several addfiles.

Comment on lines +65 to +67
Option to keep the non-overlapping gene only if the CDS size (in
nucleotide) is over the minimum size defined. Default = 0 that
means all of them are kept.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Option to keep the non-overlapping gene only if the CDS size (in
nucleotide) is over the minimum size defined. Default = 0 that
means all of them are kept.
Option to keep the non-overlapping gene only if the CDS size (in nucleotides) is over the minimum size defined. The default is 0, meaning all of them are kept.

agat --version | sed 's/AGAT\s\(.*\)/agat: "\1"/' > /var/software_versions.txt
runners:
- type: executable
- type: nextflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: nextflow
- type: nextflow

Copy link
Contributor

@dorien-er dorien-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes mostly include spelling fixes that were present in the tool's documentation itself

Copy link
Contributor

@dorien-er dorien-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants