Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedtools GroupBY #123

Merged
merged 18 commits into from
Sep 2, 2024
Merged

Bedtools GroupBY #123

merged 18 commits into from
Sep 2, 2024

Conversation

tgaspe
Copy link
Contributor

@tgaspe tgaspe commented Aug 6, 2024

Description

New component bedtools_groupby.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

Copy link
Contributor

@jakubmajercik jakubmajercik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor points :)
WDYT @rcannood or @DriesSchaumont ?

src/bedtools/bedtools_groupby/config.vsh.yaml Show resolved Hide resolved
src/bedtools/bedtools_groupby/config.vsh.yaml Outdated Show resolved Hide resolved
src/bedtools/bedtools_groupby/config.vsh.yaml Show resolved Hide resolved
@tgaspe tgaspe requested a review from jakubmajercik August 29, 2024 13:56
@jakubmajercik jakubmajercik merged commit 2b29a47 into viash-hub:main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants