Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add agat sp add start and stop #122

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add agat sp add start and stop #122

wants to merge 19 commits into from

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Aug 6, 2024 •
edited
Loading

Description

  • added agat_sp_add_start_and_stop

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011 Leila011 marked this pull request as ready for review August 6, 2024 13:40
@Leila011 Leila011 requested a review from rcannood August 6, 2024 13:40
@Leila011 Leila011 requested review from dorien-er and removed request for rcannood August 8, 2024 07:25
dorien-er
dorien-er reviewed Aug 29, 2024
View reviewed changes
src/agat/agat_sp_add_start_and_stop/config.vsh.yaml
- name: Arguments
arguments:
- name: --codon
alternatives: [--ct, --table]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alternatives: [--ct, --table]
alternatives: [--ct, --table]
min: 0
max: 33

dorien-er
dorien-er requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@dorien-er dorien-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more info on available codon tables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood left review comments

@dorien-er dorien-er dorien-er requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leila011 @rcannood @dorien-er