Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedtools bedtobam #111

Merged
merged 16 commits into from
Aug 13, 2024
Merged

Bedtools bedtobam #111

merged 16 commits into from
Aug 13, 2024

Conversation

tgaspe
Copy link
Contributor

@tgaspe tgaspe commented Aug 1, 2024

Description

Converts feature records (bed/gff/vcf) to BAM format.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

tgaspe added 9 commits August 1, 2024 11:15
- ubam option does not work properly. older version 2.27.1 works somewhat better than the version I m working 2.30.0 of bedtools.
- one solution would be to add samtools as a dependency and use it to uncompress the bam file to a sam file. However, it could be heavy.
@DriesSchaumont DriesSchaumont self-requested a review August 9, 2024 11:38
CHANGELOG.md Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/config.vsh.yaml Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/config.vsh.yaml Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/config.vsh.yaml Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/script.sh Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/test.sh Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/test.sh Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/test.sh Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/test.sh Outdated Show resolved Hide resolved
src/bedtools/bedtools_bedtobam/script.sh Show resolved Hide resolved
tgaspe added 6 commits August 10, 2024 19:35
- still need to add content check using samtools view
trying to add up samtools view to test.
- min max for map_quality option
@tgaspe tgaspe requested a review from DriesSchaumont August 13, 2024 09:06
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 68e2a57 into viash-hub:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants